[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/10] block: Allow changing 'force-share' on
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/10] block: Allow changing 'force-share' on reopen |
Date: |
Wed, 26 Sep 2018 13:39:14 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 26 Sep 2018 01:34:28 PM CEST, Kevin Wolf wrote:
>> @@ -3353,6 +3370,7 @@ void bdrv_reopen_commit(BDRVReopenState *reopen_state)
>> bs->open_flags = reopen_state->flags;
>> bs->read_only = !(reopen_state->flags & BDRV_O_RDWR);
>> bs->detect_zeroes = reopen_state->detect_zeroes;
>> + bs->force_share = reopen_state->force_share;
>
> Just changing bs->force_share without actually triggering recalculation
> of the permissions is kind of pointless, no? As the patch is, you would
> have to trigger some graph change for the new setting to take effect.
>
> The rest of the series looks good to me, so if you like, I could apply
> patches 1-9, and then you can either send a v4 of only this one or we'll
> just drop it.
Apply it without this one then. Thanks!
Berto
- [Qemu-devel] [PATCH v3 00/10] Misc reopen-related patches, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 04/10] block: Don't look for child references in append_open_options(), Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 02/10] file-posix: x-check-cache-dropped should default to false on reopen, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 07/10] file-posix: Forbid trying to change unsupported options during reopen, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 03/10] block: Remove child references from bs->{options, explicit_options}, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 06/10] block: Forbid trying to change unsupported options during reopen, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 10/10] block: Allow changing 'force-share' on reopen, Alberto Garcia, 2018/09/06
- [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen, Alberto Garcia, 2018/09/06
[Qemu-devel] [PATCH v3 05/10] block: Allow child references on reopen, Alberto Garcia, 2018/09/06
[Qemu-devel] [PATCH v3 09/10] block: Allow changing 'detect-zeroes' on reopen, Alberto Garcia, 2018/09/06
[Qemu-devel] [PATCH v3 01/10] qemu-io: Fix writethrough check in reopen, Alberto Garcia, 2018/09/06