[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/timer/cmsdk-apb-dualtimer: Add mi
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/timer/cmsdk-apb-dualtimer: Add missing 'break' statements |
|
Date: |
Mon, 24 Sep 2018 15:51:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 9/24/18 2:31 PM, Peter Maydell wrote:
> Add 'break' statements missing from a switch in the APB dual-timer
> write function. Spotted by Coverity as CID 1395626 and 1395633.
>
> Reported-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/timer/cmsdk-apb-dualtimer.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/timer/cmsdk-apb-dualtimer.c b/hw/timer/cmsdk-apb-dualtimer.c
> index ccd49753b7f..30245990f34 100644
> --- a/hw/timer/cmsdk-apb-dualtimer.c
> +++ b/hw/timer/cmsdk-apb-dualtimer.c
> @@ -296,9 +296,11 @@ static void cmsdk_apb_dualtimer_write(void *opaque,
> hwaddr offset,
> case A_TIMERITCR:
> s->timeritcr = value & R_TIMERITCR_VALID_MASK;
> cmsdk_apb_dualtimer_update(s);
> + break;
> case A_TIMERITOP:
> s->timeritop = value & R_TIMERITOP_VALID_MASK;
> cmsdk_apb_dualtimer_update(s);
> + break;
> default:
> bad_offset:
> qemu_log_mask(LOG_GUEST_ERROR,
>