[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 8/9] qcow2: Set the default cache-clean-inter
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v9 8/9] qcow2: Set the default cache-clean-interval to 10 minutes |
Date: |
Fri, 21 Sep 2018 14:56:06 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 21.09.2018 um 14:35 hat Alberto Garcia geschrieben:
> On Tue 18 Sep 2018 05:29:22 PM CEST, Leonid Bloch wrote:
> > /* New interval for cache cleanup timer */
> > r->cache_clean_interval =
> > qemu_opt_get_number(opts, QCOW2_OPT_CACHE_CLEAN_INTERVAL,
> > - s->cache_clean_interval);
> > + DEFAULT_CACHE_CLEAN_INTERVAL);
>
> I just realized we're ignoring the old value (s->cache_clean_interval)
> here. What's the consequence of this? (this was a change made by Kevin
> Wolf in 5b0959a7d432062dcd740f8065004285b15695fa).
I think the consequence is that bdrv_reopen() will not keep the current
value if the option isn't given, but reset it to the default.
Kevin
- [Qemu-devel] [PATCH v9 0/9] Take the image size into account when allocating the L2 cache, Leonid Bloch, 2018/09/18
- [Qemu-devel] [PATCH v9 1/9] qcow2: Options' documentation fixes, Leonid Bloch, 2018/09/18
- [Qemu-devel] [PATCH v9 3/9] qcow2: Make sizes more humanly readable, Leonid Bloch, 2018/09/18
- [Qemu-devel] [PATCH v9 2/9] include: Add a lookup table of sizes, Leonid Bloch, 2018/09/18
- [Qemu-devel] [PATCH v9 4/9] qcow2: Avoid duplication in setting the refcount cache size, Leonid Bloch, 2018/09/18
- [Qemu-devel] [PATCH v9 9/9] qcow2: Explicit number replaced by a constant, Leonid Bloch, 2018/09/18
- [Qemu-devel] [PATCH v9 8/9] qcow2: Set the default cache-clean-interval to 10 minutes, Leonid Bloch, 2018/09/18
- [Qemu-devel] [PATCH v9 6/9] qcow2: Increase the default upper limit on the L2 cache size, Leonid Bloch, 2018/09/18
- [Qemu-devel] [PATCH v9 7/9] qcow2: Resize the cache upon image resizing, Leonid Bloch, 2018/09/18
- [Qemu-devel] [PATCH v9 5/9] qcow2: Assign the L2 cache relatively to the image size, Leonid Bloch, 2018/09/18