Re: [Qemu-devel] [PATCH 3/5] scsi: remove unused lsi53c895a_create() and lsi53c810_create() functions

[Philippe Mathieu-Daudé]

On 9/19/18 7:20 PM, Mark Cave-Ayland wrote:
> Now that these functions are no longer required they can be removed.
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  hw/scsi/lsi53c895a.c | 14 --------------
>  include/hw/pci/pci.h |  2 --
>  2 files changed, 16 deletions(-)
> 
> diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
> index 8f5ab82d57..f5cbbf653c 100644
> --- a/hw/scsi/lsi53c895a.c
> +++ b/hw/scsi/lsi53c895a.c
> @@ -2277,20 +2277,6 @@ static void lsi53c895a_register_types(void)
>  
>  type_init(lsi53c895a_register_types)
>  
> -void lsi53c895a_create(PCIBus *bus)
> -{
> -    LSIState *s = LSI53C895A(pci_create_simple(bus, -1, "lsi53c895a"));
> -
> -    scsi_bus_legacy_handle_cmdline(&s->bus);
> -}
> -
> -void lsi53c810_create(PCIBus *bus, int devfn)
> -{
> -    LSIState *s = LSI53C895A(pci_create_simple(bus, devfn, "lsi53c810"));
> -
> -    scsi_bus_legacy_handle_cmdline(&s->bus);
> -}
> -
>  void lsi53c8xx_handle_legacy_cmdline(DeviceState *lsi_dev)
>  {
>      LSIState *s = LSI53C895A(lsi_dev);
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
> index 0d907dc084..e6514bba23 100644
> --- a/include/hw/pci/pci.h
> +++ b/include/hw/pci/pci.h
> @@ -707,8 +707,6 @@ PCIDevice *pci_create_simple_multifunction(PCIBus *bus, 
> int devfn,
>  PCIDevice *pci_create(PCIBus *bus, int devfn, const char *name);
>  PCIDevice *pci_create_simple(PCIBus *bus, int devfn, const char *name);
>  
> -void lsi53c895a_create(PCIBus *bus);
> -void lsi53c810_create(PCIBus *bus, int devfn);
>  void lsi53c8xx_handle_legacy_cmdline(DeviceState *lsi_dev);
>  
>  qemu_irq pci_allocate_irq(PCIDevice *pci_dev);
>