[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 31/35] translate-all: drop BQL assertion from cp
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 31/35] translate-all: drop BQL assertion from cpu_interrupt |
Date: |
Wed, 19 Sep 2018 23:18:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 9/17/18 6:30 PM, Emilio G. Cota wrote:
> This patch explicitly drops the BQL assertion from
> the user-mode version; previous patches have taken
> care of softmmu's cpu_interrupt.
>
> Cc: Peter Crosthwaite <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> accel/tcg/translate-all.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
> index 364757c677..911436a8d7 100644
> --- a/accel/tcg/translate-all.c
> +++ b/accel/tcg/translate-all.c
> @@ -2350,7 +2350,6 @@ void dump_opcount_info(FILE *f, fprintf_function
> cpu_fprintf)
>
> void cpu_interrupt(CPUState *cpu, int mask)
> {
> - g_assert(qemu_mutex_iothread_locked());
> atomic_or(&cpu->interrupt_request, mask);
> atomic_set(&cpu->icount_decr.u16.high, -1);
> }
>
- Re: [Qemu-devel] [PATCH 30/35] tcg: drop BQL assertion from tcg_handle_interrupt, (continued)
- [Qemu-devel] [PATCH 29/35] exec: drop BQL from cpu_reset_interrupt, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 22/35] target/ppc: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 23/35] target/s390x: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 31/35] translate-all: drop BQL assertion from cpu_interrupt, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 32/35] target/i386/kvm: do not acquire the BQL to call cpu_reset_interrupt, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 33/35] target/ppc: do not acquire the BQL to call cpu_interrupt, Emilio G. Cota, 2018/09/17
- Re: [Qemu-devel] [PATCH 00/35] exec: drop BQL from interrupt handling, David Hildenbrand, 2018/09/18
- Re: [Qemu-devel] [PATCH 00/35] exec: drop BQL from interrupt handling, Mark Cave-Ayland, 2018/09/20