qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] qapi/misc.json: Clarify about usage of QMP 'cpu-add


From: Kashyap Chamarthy
Subject: [Qemu-devel] [PATCH] qapi/misc.json: Clarify about usage of QMP 'cpu-add'
Date: Tue, 18 Sep 2018 15:23:03 +0200

Eduardo Habkost mentioned on IRC that the intended functionality of QMP
'cpu-add' is replaced with a combination of 'query-hotpluggable-cpus'
and 'device_add'.  And 'cpu-add' is likely to be deprecated in the
future.

Add a note in the QAPI schema to reflect that.

Suggested-by: Eduardo Habkost <address@hidden
Signed-off-by: Kashyap Chamarthy <address@hidden>
---
 qapi/misc.json | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/qapi/misc.json b/qapi/misc.json
index d450cfef21..178a94b904 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -1104,7 +1104,13 @@
 ##
 # @cpu-add:
 #
-# Adds CPU with specified ID
+# Adds CPU with specified ID.
+#
+# Notes: This command is likely to be deprecated in the future.  The
+#        way to achieve the intended functionality of 'cpu-add', which
+#        is to allow CPU hot-plug, is possible with the combination of
+#        QMP 'query-hotpluggable-cpus' and 'device_add'.  (And
+#        hot-unplug via 'device_del'.)
 #
 # @id: ID of CPU to be created, valid values [0..max_cpus)
 #
-- 
2.17.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]