Re: [Qemu-devel] [PATCH] accel/tcg: Remove dead code

[Paolo Bonzini]

On 17/09/2018 19:08, Thomas Huth wrote:
> The global cpu_single_env variable has been removed more than 5 years
> ago, so apparently nobody used this dead debug code in that timeframe
> anymore. Thus let's remove it completely now.
> 
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  accel/tcg/translate-all.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
> index 898c3bb..e589c35 100644
> --- a/accel/tcg/translate-all.c
> +++ b/accel/tcg/translate-all.c
> @@ -2011,15 +2011,6 @@ void tb_invalidate_phys_page_fast(struct 
> page_collection *pages,
>  {
>      PageDesc *p;
>  
> -#if 0
> -    if (1) {
> -        qemu_log("modifying code at 0x%x size=%d EIP=%x PC=%08x\n",
> -                  cpu_single_env->mem_io_vaddr, len,
> -                  cpu_single_env->eip,
> -                  cpu_single_env->eip +
> -                  (intptr_t)cpu_single_env->segs[R_CS].base);
> -    }
> -#endif
>      assert_memory_lock();
>  
>      p = page_find(start >> TARGET_PAGE_BITS);
> 

Queued, thanks.

Paolo