[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v5 1/6] pci_expander_bridge: add type TYPE_PXB_PCI
From: |
Zihan Yang |
Subject: |
Re: [Qemu-devel] [RFC v5 1/6] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST |
Date: |
Tue, 18 Sep 2018 14:40:14 +0800 |
Gerd Hoffmann <address@hidden> 于2018年9月18日周二 下午1:09写道:
>
> Hi,
>
> > +static void pxb_pcie_host_get_mmcfg_base(Object *obj, Visitor *v, const
> > char *name,
> ^^^^
> > + void *opaque, Error **errp)
> > +{
> > + PCIExpressHost *e = PCIE_HOST_BRIDGE(obj);
> > +
> > + visit_type_uint64(v, name, &e->size, errp);
> ^^^^
>
> cut&paste bug?
Thanks for pointing out. I was wondering how I got the right behavior with
wrong code, then I find I somehow fix it in patch 3/6... It will be solved in
next version.
> cheers,
> Gerd
>
- [Qemu-devel] [RFC v5 0/6] pci_expander_brdige: support separate pci domain for pxb-pcie, Zihan Yang, 2018/09/17
- [Qemu-devel] [RFC v5 2/6] pci_expander_bridge: add domain_nr and max_bus property for pxb-pcie, Zihan Yang, 2018/09/17
- [Qemu-devel] [RFC v5 1/6] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST, Zihan Yang, 2018/09/17
- [Qemu-devel] [RFC v5 3/6] acpi-build: allocate mcfg for pxb-pcie host bridges, Zihan Yang, 2018/09/17
- [Qemu-devel] [RFC v5 4/6] i386/acpi-build: describe new pci domain in AML, Zihan Yang, 2018/09/17
- [Qemu-devel] [RFC v5 5/6] pci_expander_bridge: add config_write callback for pxb-pcie, Zihan Yang, 2018/09/17
- [Qemu-devel] [RFC v5 6/6] pci_expander_bridge: inform seabios of desired mcfg size via hidden bar, Zihan Yang, 2018/09/17
- Re: [Qemu-devel] [RFC v5 0/6] pci_expander_brdige: support separate pci domain for pxb-pcie, Michael S. Tsirkin, 2018/09/18