[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] scsi-block: Deprecate rotation_rate
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH] scsi-block: Deprecate rotation_rate |
|
Date: |
Mon, 17 Sep 2018 18:00:26 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 17/09/2018 10:31, Fam Zheng wrote:
> This option is added together with scsi-disk but is never honoured,
> becuase we don't emulate the VPD page for scsi-block. We could intercept
> and inject the user specified value like for max xfer len, but it's
> probably not helpful since the intent of 070f80095ad was for random
> entropy aspects, not for performance. If emulated rotation rate is
> desired, scsi-hd is more suitable.
>
> Signed-off-by: Fam Zheng <address@hidden>
>
> ---
>
> RFC to discuss about if we want to keep the option. Another possibility
> is, naturally, to actually write code to make use of the option.
Sounds good. I queued the patch.
Paolo