|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH v6 21/25] replay: replay BH for IDE trim operation |
| Date: | Mon, 17 Sep 2018 15:39:24 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 17/09/2018 13:57, Pavel Dovgalyuk wrote: >> From: Peter Maydell [mailto:address@hidden >> On 14 September 2018 at 16:19, Paolo Bonzini <address@hidden> wrote: >>> On 14/09/2018 16:00, John Snow wrote: >>>>> Maybe not. We can hardly analyze all peripheral devices code and fix all >>>>> the calls. >>>>> But I think we can improve that patch and at least look through ide core >>>>> to fix other >> calls. >>>>> >>>>> Pavel Dovgalyuk >>>>> >>>> It just seems odd that if you're working on a replay mechanism that >>>> requires you to intercept my QEMU API calls that you're only changing a >>>> trim callback. >>> >>> You need it only here because the block layer is already calling >>> replay_bh_schedule_event (actually replay_bh_schedule_oneshot_event >>> after patch 22 of this series) on reads and writes. >> >> Do we have documentation describing when a device model needs to care >> about record/replay ? > > Not yet. > But how we are suppose this doc to be seen by everyone? Put it in docs/devel. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |