[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] vnc: call sasl_server_init() only when requi
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] vnc: call sasl_server_init() only when required |
|
Date: |
Mon, 17 Sep 2018 08:23:24 +0200 |
|
User-agent: |
NeoMutt/20180716 |
On Fri, Sep 07, 2018 at 10:36:34AM +0400, Marc-André Lureau wrote:
> VNC server is calling sasl_server_init() during startup of QEMU, even
> if SASL auth has not been enabled.
>
> This may create undesirable warnings like "Could not find keytab file:
> /etc/qemu/krb5.tab" when the user didn't configure SASL on host and
> started VNC server.
>
> Instead, only initialize SASL when needed. Note that HMP/QMP "change
> vnc" calls vnc_display_open() again, which will initialize SASL if
> needed.
>
> Fix assignment in if condition, while touching this code.
>
> Related to:
> https://bugzilla.redhat.com/show_bug.cgi?id=1609327
Added to ui queue.
thanks,
Gerd