Re: [Qemu-devel] [PATCH 2/2] hw/vfio/display: add ramfb support

[Gerd Hoffmann]

  Hi,

> > Also libvirt manages hotpluggability per device *class*, not per device
> > *instance*.  So a device being hotpluggable or not depending on some
> > device property is a problem for libvirt ...
> > 
> > I'm open to suggestions how to handle this better, as long as the
> > libvirt people are on board with the approach.
> 
> Ok, so we need a new class to handle making a device non-hotpluggable,
> but I'm still not sure whether we should make:
> 
>  -device vfio-pci-ramfb
> 
> or
> 
>  -device vfio-pci-nohotplug,ramfb=on
> 
> Where ramfb would be a property only available on the nohotplug class
> variant.

I'm fine with the latter.

> The latter seems to provide a lot more flexibility, but which
> is more practical for libvirt?

Any comment from the libvirt camp?

thanks,
  Gerd