Re: [Qemu-devel] [PATCH v3 09/10] block: Allow changing 'detect-zeroes' on reopen

[Max Reitz]

On 06.09.18 11:37, Alberto Garcia wrote:
> 'detect-zeroes' is one of the basic BlockdevOptions available for all
> drivers, but it's not handled by bdrv_reopen_prepare(), so any attempt
> to change it results in an error:
> 
>    (qemu) qemu-io virtio0 "reopen -o detect-zeroes=on"
>    Cannot change the option 'detect-zeroes'
> 
> Since there's no reason why we shouldn't allow changing it and the
> implementation is simple let's just do it.
> 
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
>  block.c               | 64 
> ++++++++++++++++++++++++++++++++-------------------
>  include/block/block.h |  1 +
>  2 files changed, 41 insertions(+), 24 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature