[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] scsi: move lsi53c895a structures and define
From: |
Mark Cave-Ayland |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] scsi: move lsi53c895a structures and defines into separate lsi53c895a.h file |
Date: |
Thu, 6 Sep 2018 17:20:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 06/09/18 12:52, Thomas Huth wrote:
> On 2018-09-06 07:57, Mark Cave-Ayland wrote:
>> There is also one small change to the new header file which is the addition
>> of the previously missing LSI53C810 define.
>>
>> Signed-off-by: Mark Cave-Ayland <address@hidden>
>> ---
>> hw/scsi/lsi53c895a.c | 116 +-----------------------------------
>> include/hw/scsi/lsi53c895a.h | 137
>> +++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 138 insertions(+), 115 deletions(-)
>> create mode 100644 include/hw/scsi/lsi53c895a.h
> [...]
>> diff --git a/include/hw/scsi/lsi53c895a.h b/include/hw/scsi/lsi53c895a.h
>> new file mode 100644
>> index 0000000000..d80cb78c69
>> --- /dev/null
>> +++ b/include/hw/scsi/lsi53c895a.h
>> @@ -0,0 +1,137 @@
>> +/*
>> + * QEMU LSI53C895A SCSI Host Bus Adapter emulation
>> + *
>> + * Copyright (c) 2006 CodeSourcery.
>> + * Written by Paul Brook
>> + *
>> + * This code is licensed under the LGPL.
>> + */
>> +
>> +#ifndef LSI_H
>> +#define LSI_H
>> +
>> +#include "qemu/osdep.h"
>
> Please don't include osdep.h from a header, that should only be done
> from .c files.
Ah yes, my mistake (obviously it was a cut/paste from the .c file).
I wonder if this is something to teach checkpatch about?
ATB,
Mark.
- [Qemu-devel] [PATCH 0/3] scsi: remove lsi53c895a_create() and lsi53c810_create() functions, Mark Cave-Ayland, 2018/09/06
- [Qemu-devel] [PATCH 1/3] scsi: move lsi53c895a structures and defines into separate lsi53c895a.h file, Mark Cave-Ayland, 2018/09/06
- [Qemu-devel] [PATCH 3/3] scsi: remove unused lsi53c895a_create() and lsi53c810_create() functions, Mark Cave-Ayland, 2018/09/06
- [Qemu-devel] [PATCH 2/3] scsi: move lsi53c895a_create() and lsi53c810_create() callers to pci_create_simple(), Mark Cave-Ayland, 2018/09/06
- Re: [Qemu-devel] [PATCH 0/3] scsi: remove lsi53c895a_create() and lsi53c810_create() functions, Thomas Huth, 2018/09/06
- Re: [Qemu-devel] [PATCH 0/3] scsi: remove lsi53c895a_create() and lsi53c810_create() functions, Peter Maydell, 2018/09/06
- Re: [Qemu-devel] [PATCH 0/3] scsi: remove lsi53c895a_create() and lsi53c810_create() functions, Thomas Huth, 2018/09/06
- Re: [Qemu-devel] [PATCH 0/3] scsi: remove lsi53c895a_create() and lsi53c810_create() functions, Peter Maydell, 2018/09/06
- Re: [Qemu-devel] [PATCH 0/3] scsi: remove lsi53c895a_create() and lsi53c810_create() functions, Mark Cave-Ayland, 2018/09/06
- Re: [Qemu-devel] [PATCH 0/3] scsi: remove lsi53c895a_create() and lsi53c810_create() functions, Thomas Huth, 2018/09/07
- Re: [Qemu-devel] [PATCH 0/3] scsi: remove lsi53c895a_create() and lsi53c810_create() functions, Mark Cave-Ayland, 2018/09/07