|
From: | Alberto Garcia |
Subject: | Re: [Qemu-devel] [PATCH v2 08/10] block: Allow changing 'discard' on reopen |
Date: | Wed, 05 Sep 2018 18:53:09 +0200 |
User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 03 Sep 2018 04:34:06 PM CEST, Alberto Garcia <address@hidden> wrote: > + value = qemu_opt_get_del(opts, "discard"); > + if (value != NULL) { > + if (bdrv_parse_discard_flags(value, &reopen_state->flags) != 0) { > + error_setg(errp, "Invalid discard option"); > + ret = -EINVAL; > + goto error; > + } > + } I just realized that we're leaking the string here. qemu_opt_get_del() expects that the returned value is freed by the caller. I'll correct all the patches from this series with this problem and resend the series. Berto
[Prev in Thread] | Current Thread | [Next in Thread] |