[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V12 10/19] qmp event: Add COLO_EXIT event to notify
From: |
Zhang Chen |
Subject: |
[Qemu-devel] [PATCH V12 10/19] qmp event: Add COLO_EXIT event to notify users while exited COLO |
Date: |
Mon, 3 Sep 2018 12:38:51 +0800 |
From: zhanghailiang <address@hidden>
If some errors happen during VM's COLO FT stage, it's important to
notify the users of this event. Together with 'x-colo-lost-heartbeat',
Users can intervene in COLO's failover work immediately.
If users don't want to get involved in COLO's failover verdict,
it is still necessary to notify users that we exited COLO mode.
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Li Zhijian <address@hidden>
Signed-off-by: Zhang Chen <address@hidden>
Signed-off-by: Zhang Chen <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
---
migration/colo.c | 31 +++++++++++++++++++++++++++++++
qapi/migration.json | 38 ++++++++++++++++++++++++++++++++++++++
2 files changed, 69 insertions(+)
diff --git a/migration/colo.c b/migration/colo.c
index d3163b51c8..761fbb9f78 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -28,6 +28,7 @@
#include "net/colo-compare.h"
#include "net/colo.h"
#include "block/block.h"
+#include "qapi/qapi-events-migration.h"
static bool vmstate_loading;
static Notifier packets_compare_notifier;
@@ -514,6 +515,23 @@ out:
qemu_fclose(fb);
}
+ /*
+ * There are only two reasons we can get here, some error happened
+ * or the user triggered failover.
+ */
+ switch (failover_get_state()) {
+ case FAILOVER_STATUS_NONE:
+ qapi_event_send_colo_exit(COLO_MODE_PRIMARY,
+ COLO_EXIT_REASON_ERROR, NULL);
+ break;
+ case FAILOVER_STATUS_REQUIRE:
+ qapi_event_send_colo_exit(COLO_MODE_PRIMARY,
+ COLO_EXIT_REASON_REQUEST, NULL);
+ break;
+ default:
+ abort();
+ }
+
/* Hope this not to be too long to wait here */
qemu_sem_wait(&s->colo_exit_sem);
qemu_sem_destroy(&s->colo_exit_sem);
@@ -746,6 +764,19 @@ out:
error_report_err(local_err);
}
+ switch (failover_get_state()) {
+ case FAILOVER_STATUS_NONE:
+ qapi_event_send_colo_exit(COLO_MODE_SECONDARY,
+ COLO_EXIT_REASON_ERROR, NULL);
+ break;
+ case FAILOVER_STATUS_REQUIRE:
+ qapi_event_send_colo_exit(COLO_MODE_SECONDARY,
+ COLO_EXIT_REASON_REQUEST, NULL);
+ break;
+ default:
+ abort();
+ }
+
if (fb) {
qemu_fclose(fb);
}
diff --git a/qapi/migration.json b/qapi/migration.json
index f62d3f9a4b..9b3b1c0c4e 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -932,6 +932,44 @@
{ 'enum': 'FailoverStatus',
'data': [ 'none', 'require', 'active', 'completed', 'relaunch' ] }
+##
+# @COLO_EXIT:
+#
+# Emitted when VM finishes COLO mode due to some errors happening or
+# at the request of users.
+#
+# @mode: report COLO mode when COLO exited.
+#
+# @reason: describes the reason for the COLO exit.
+#
+# Since: 3.1
+#
+# Example:
+#
+# <- { "timestamp": {"seconds": 2032141960, "microseconds": 417172},
+# "event": "COLO_EXIT", "data": {"mode": "primary", "reason": "request" }
}
+#
+##
+{ 'event': 'COLO_EXIT',
+ 'data': {'mode': 'COLOMode', 'reason': 'COLOExitReason' } }
+
+##
+# @COLOExitReason:
+#
+# The reason for a COLO exit
+#
+# @none: no failover has ever happened. This can't occur in the
+# COLO_EXIT event, only in the result of query-colo-status.
+#
+# @request: COLO exit is due to an external request
+#
+# @error: COLO exit is due to an internal error
+#
+# Since: 3.1
+##
+{ 'enum': 'COLOExitReason',
+ 'data': [ 'none', 'request', 'error' ] }
+
##
# @x-colo-lost-heartbeat:
#
--
2.17.GIT
- Re: [Qemu-devel] [PATCH V12 01/19] filter-rewriter: Add TCP state machine and fix memory leak in connection_track_table, (continued)
- [Qemu-devel] [PATCH V12 02/19] colo-compare: implement the process of checkpoint, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 03/19] colo-compare: use notifier to notify packets comparing result, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 04/19] COLO: integrate colo compare with colo frame, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 05/19] COLO: Add block replication into colo process, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 06/19] COLO: Remove colo_state migration struct, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 07/19] COLO: Load dirty pages into SVM's RAM cache firstly, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 08/19] ram/COLO: Record the dirty pages that SVM received, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 09/19] COLO: Flush memory data from ram cache, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 10/19] qmp event: Add COLO_EXIT event to notify users while exited COLO,
Zhang Chen <=
- [Qemu-devel] [PATCH V12 11/19] qapi/migration.json: Rename COLO unknown mode to none mode., Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 12/19] qapi: Add new command to query colo status, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 13/19] savevm: split the process of different stages for loadvm/savevm, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 14/19] COLO: flush host dirty ram from cache, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 15/19] filter: Add handle_event method for NetFilterClass, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 16/19] filter-rewriter: handle checkpoint and failover event, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 17/19] COLO: notify net filters about checkpoint/failover event, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 18/19] COLO: quick failover process by kick COLO thread, Zhang Chen, 2018/09/03
- [Qemu-devel] [PATCH V12 19/19] docs: Add COLO status diagram to COLO-FT.txt, Zhang Chen, 2018/09/03