Re: [Qemu-devel] [PATCH] input-linux: toggle for lock keys

[Ryan El Kochta]

On August 30, 2018 6:51 AM, Gerd Hoffmann <address@hidden> wrote:

> On Mon, Aug 27, 2018 at 01:49:22PM +0000, Ryan El Kochta wrote:
>
> > I personally use the Scroll Lock key. On Linux, Scroll Lock (along
> > with all the other lock keys) is easy to disable with an xmodmap
> > command. On Windows (or, I'd assume, other guests), it requires third
> > party software, which is why it's likely easier to just filter them
> > out from QEMU.
>
> Ok, disable with xmodmap is a reasonable approach for that key.
> I think it would be a good idea to document that.
>
> I'd suggest to add a single option, to configure alternative toggle
> key(s), with just a few hard-coded variants which actually make sense.
> Something like grab-toggle={two-shift,scroll-lock}. Not sure whenever
> we need the other lock keys. scroll lock is probably the
> least-frequently used key and therefore the best choice for the
> purpose.
>
> In case scroll-lock is selected we can automatically ignore it, without
> ignore_scroll_lock=off option.
>
> cheers,
> Gerd

That's a wonderful idea. Would you be comfortable with
grab_toggle=custom:x:x as well?

Thanks,

Ryan El Kochta