Re: [Qemu-devel] [PATCH v6 03/13] qapi: remove error checks for event emission

[Markus Armbruster]

Markus Armbruster <address@hidden> writes:

> Peter Xu <address@hidden> writes:
>
>> In the whole QAPI event emission code we're passing in an Error* object
>> along the whole stack.  That's never useful since it never fails after
>> all.  Remove that.
>
> This is the interesting part.  We'll see below why it can't fail.
>
>> Then, remove that parameter from all the callers to send an event.
>
> This is the mechanical part.  The callers pass &error_abort, except for
> one that passes NULL.
>
> The patch moves the &error_abort argument from the qapi_event_send_FOO()
> calls to the places where the argument is used.  No effect except for
> the caller that passes NULL.  That one now asserts "no error".
>
>> Suggested-by: Eric Blake <address@hidden>
>> Suggested-by: Markus Armbruster <address@hidden>
>> Signed-off-by: Peter Xu <address@hidden>
>> ---
>
> Patch quoted except for the parts that drop &error_abort from
> qapi_event_send_FOO() calls:
>
> [...]
>> diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
>> index c2e11465f0..6d3cffd548 100644
>> --- a/docs/devel/qapi-code-gen.txt
>> +++ b/docs/devel/qapi-code-gen.txt

Missing:

   @@ -1340,7 +1340,7 @@ Example:
        #include "example-qapi-types.h"


   -    void qapi_event_send_my_event(Error **errp);
   +    void qapi_event_send_my_event(void);

        typedef enum example_QAPIEvent {
            EXAMPLE_QAPI_EVENT_MY_EVENT = 0,

>> @@ -1356,10 +1356,9 @@ Example:
>>      $ cat qapi-generated/example-qapi-events.c
>>  [Uninteresting stuff omitted...]
>>  
>> -    void qapi_event_send_my_event(Error **errp)
>> +    void qapi_event_send_my_event(void)
>>      {
>>          QDict *qmp;
>> -        Error *err = NULL;
>>          QMPEventFuncEmit emit;
>>  
>>          emit = qmp_event_get_func_emit();
>> @@ -1369,9 +1368,8 @@ Example:
>>  
>>          qmp = qmp_event_build_dict("MY_EVENT");
>>  
>> -        emit(EXAMPLE_QAPI_EVENT_MY_EVENT, qmp, &err);
>> +        emit(EXAMPLE_QAPI_EVENT_MY_EVENT, qmp);
>>  
>> -        error_propagate(errp, err);
>>          qobject_unref(qmp);
>>      }
>>  
[...]