|
From: | Markus Armbruster |
Subject: | Re: [Qemu-devel] [PATCH v4 09/10] qga: process_event() simplification |
Date: | Thu, 30 Aug 2018 15:57:07 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes: > Simplify the code around qmp_dispatch(): > - rely on qmp_dispatch/check_obj() for message checking > - have a single send_response() point > - constify send_response() argument > > It changes a couple of error messages: > > * When @req isn't a dictionary, from > Invalid JSON syntax > to > QMP input must be a JSON object > > * When @req lacks member "execute", from > this feature or command is not currently supported > to > QMP input lacks member 'execute' > > Signed-off-by: Marc-André Lureau <address@hidden> > Reviewed-by: Michael Roth <address@hidden> Reviewed-by: Markus Armbruster <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |