[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/20] memory-device: use memory device termi
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/20] memory-device: use memory device terminology in error messages |
Date: |
Thu, 30 Aug 2018 09:58:37 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
* David Hildenbrand (address@hidden) wrote:
> While we rephrased most error messages, we missed these.
>
> Signed-off-by: David Hildenbrand <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hw/mem/memory-device.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
> index efacbc2a7d..0d9892b715 100644
> --- a/hw/mem/memory-device.c
> +++ b/hw/mem/memory-device.c
> @@ -87,7 +87,7 @@ static void memory_device_check_addable(MachineState *ms,
> uint64_t size,
> memory_device_used_region_size(OBJECT(ms), &used_region_size);
> if (used_region_size + size > ms->maxram_size - ms->ram_size) {
> error_setg(errp, "not enough space, currently 0x%" PRIx64
> - " in use of total hot pluggable 0x" RAM_ADDR_FMT,
> + " in use of total space for memory devices 0x"
> RAM_ADDR_FMT,
> used_region_size, ms->maxram_size - ms->ram_size);
> return;
> }
> @@ -145,12 +145,12 @@ uint64_t memory_device_get_free_addr(MachineState *ms,
> const uint64_t *hint,
> if (hint) {
> new_addr = *hint;
> if (new_addr < address_space_start) {
> - error_setg(errp, "can't add memory [0x%" PRIx64 ":0x%" PRIx64
> + error_setg(errp, "can't add memory device [0x%" PRIx64 ":0x%"
> PRIx64
> "] before 0x%" PRIx64, new_addr, size,
> address_space_start);
> return 0;
> } else if ((new_addr + size) > address_space_end) {
> - error_setg(errp, "can't add memory [0x%" PRIx64 ":0x%" PRIx64
> + error_setg(errp, "can't add memory device [0x%" PRIx64 ":0x%"
> PRIx64
> "] beyond 0x%" PRIx64, new_addr, size,
> address_space_end);
> return 0;
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v2 00/20] memory-device: complete refactoring + virtio-pmem, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 02/20] memory-device: use memory device terminology in error messages, David Hildenbrand, 2018/08/29
- Re: [Qemu-devel] [PATCH v2 02/20] memory-device: use memory device terminology in error messages,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH v2 01/20] memory-device: fix error message when hinted address is too small, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 03/20] memory-device: introduce separate config option, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 04/20] memory-device: get_region_size()/get_plugged_size() might fail, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 05/20] memory-device: convert get_region_size() to get_memory_region(), David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 06/20] memory-device: document MemoryDeviceClass, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 07/20] memory-device: add device class function set_addr(), David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 08/20] pc-dimm: implement memory device class function set_addr(), David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 09/20] memory-device: complete factoring out pre_plug handling, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 10/20] memory-device: complete factoring out plug handling, David Hildenbrand, 2018/08/29