Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Add all MXU opcodes

[Aleksandar Markovic]

> From: Craig Janeczek <address@hidden>
> Sent: Tuesday, August 28, 2018 3:00 PM
> To: address@hidden
> Cc: Aleksandar Markovic; address@hidden; Craig Janeczek
> Subject: [PATCH v3 2/8] target/mips: Add all MXU opcodes
> 
> Adds all MXU opcodes to the opcode enum. The MXU opcodes overlap with
> existing misc and Loongson 2F copcodes. The enums were updated to
> reflect the multiple possible meanings where applicable.
> 
> Signed-off-by: Craig Janeczek <address@hidden>

It is good that all codes are covered, but this situation with overlap is 
unnatural.

Try creating a separate enum for MXU opcodes, and rearranging switch statement, 
taking into account what instructions set is supported by the CPU in question.