Re: [Qemu-devel] [PATCH 1/7] target/mips: Add MXU register support

[Aleksandar Markovic]

> From: Craig Janeczek <address@hidden>
> Sent: Friday, August 24, 2018 9:44 PM
>
> Subject: [PATCH 1/7] target/mips: Add MXU register support
> 
>This commit makes the MXU registers and the helper functions for
> reading/writing to them. This is required for full MXU instruction
> support.

> Signed-off-by: Craig Janeczek <address@hidden>

Also, Craig,

This patch will cause compiler errors if QEMU is built with clang, with this 
patch as the last one. Clang will complain about unused functions. This will 
affect bisect algorithms. you should move definition of the functions to the 
patches where they are used for the first time in the series.

Otherwise, overall, we want the content of your series integrated, you just 
need to improve/correct the code.

Regards,
Aleksandar