Re: [Qemu-devel] [PATCH 1/7] target/mips: Add MXU register support

[Aleksandar Markovic]

> From: Craig Janeczek <address@hidden>
> Sent: Friday, August 24, 2018 9:44 PM
>
> Subject: [PATCH 1/7] target/mips: Add MXU register support
> 
> This commit makes the MXU registers and the helper functions for
> reading/writing to them. This is required for full MXU instruction
> support.

Hi, Craig,

The term "helper function" is good in general terminology sense, however, in 
QEMU terminology, it is used for something else (see op_helper.c for examples), 
and not for the case similar to the functions in this patch. Your functions 
generate "inline" code, in QEMU terminology, which is opposite to "helper" 
functions. Just don't use the word "helper" in the commit message. Use 
"wrapper", "utility", or similar word.

Thanks,
Aleksandar