Re: [Qemu-devel] [PULL v3 00/46] MIPS queue August 21, 2018 v3

[Peter Maydell]

On 21 August 2018 at 14:31, Aleksandar Markovic
<address@hidden> wrote:
> From: Aleksandar Markovic <address@hidden>
>
> The following changes since commit 659b11e7a7239529cfdb4968418268ff9aa22d88:
>
>   Merge remote-tracking branch 
> 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging 
> (2018-08-21 11:36:15 +0100)
>
> are available in the git repository at:
>
>   https://github.com/AMarkovic/qemu tags/mips-queue-aug-21-2018
>
> for you to fetch changes up to 7bfa634d0a73b74f2b84a5cd13d055e61210c356:
>
>   target/mips: Add definition of nanoMIPS I7200 CPU (2018-08-21 14:59:32 
> +0200)
>
> ----------------------------------------------------------------
> MIPS queue August 21, 2018 v3
>
> In v2, the initial ('since') commit was wrong.
> In v1, there were three missing "Reviewed-by" lines. Please use
>
> ----------------------------------------------------------------

Hi; I'm afraid this fails to build on clang for the linux-user
targets:

/home/petmay01/linaro/qemu-for-merges/target/mips/translate.c:1947:20:
error: unused function 'check_cp0_mt' [-Werror,-Wunused-function]
static inline void check_cp0_mt(DisasContext *ctx)
                   ^
1 error generated.

This function is only called inside #ifndef CONFIG_USER_ONLY
sections, but the function definition is not similarly guarded.

thanks
-- PMM