[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 04/10] check: Only test usb-xhci-nec when it
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v3 04/10] check: Only test usb-xhci-nec when it is compiled in |
Date: |
Wed, 22 Aug 2018 16:32:06 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Thomas Huth <address@hidden> wrote:
> On 2018-08-22 11:54, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> tests/Makefile.include | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index 15296be246..9a918f7655 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -290,8 +290,9 @@ endif
>> gcov-files-i386-$(CONFIG_USB_EHCI) += hw/usb/hcd-ehci.c
>> gcov-files-i386-y += hw/usb/dev-hid.c
>> gcov-files-i386-y += hw/usb/dev-storage.c
>> -check-qtest-i386-y += tests/usb-hcd-xhci-test$(EXESUF)
>> -gcov-files-i386-y += hw/usb/hcd-xhci.c
>> +check-qtest-i386-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF)
>> +gcov-files-i386-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c
>> +gcov-files-i386-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci-nec.c
>> check-qtest-i386-y += tests/cpu-plug-test$(EXESUF)
>> check-qtest-i386-y += tests/q35-test$(EXESUF)
>> check-qtest-i386-y += tests/vmgenid-test$(EXESUF)
>> @@ -349,8 +350,8 @@ check-qtest-ppc64-$(CONFIG_USB_OHCI) +=
>> tests/usb-hcd-ohci-test$(EXESUF)
>> gcov-files-ppc64-$(CONFIG_USB_OHCI) += hw/usb/hcd-ohci.c
>> check-qtest-ppc64-$(CONFIG_USB_UHCI) += tests/usb-hcd-uhci-test$(EXESUF)
>> gcov-files-ppc64-$(CONFIG_USB_UHCI) += hw/usb/hcd-uhci.c
>> -check-qtest-ppc64-y += tests/usb-hcd-xhci-test$(EXESUF)
>> -gcov-files-ppc64-y += hw/usb/hcd-xhci.c
>> +check-qtest-ppc64-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF)
>> +gcov-files-ppc64-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c
>
> Add hcd-xhci-nec.c here, too?
>
> Anyway:
>
> Reviewed-by: Thomas Huth <address@hidden>
Thanks, done.
- [Qemu-devel] [PATCH v3 00/10] Don't check disabled drivers, Juan Quintela, 2018/08/22
- [Qemu-devel] [PATCH v3 02/10] check: Use land/lor when possible, Juan Quintela, 2018/08/22
- [Qemu-devel] [PATCH v3 03/10] check: Only test isa-testdev when it is compiled in, Juan Quintela, 2018/08/22
- [Qemu-devel] [PATCH v3 04/10] check: Only test usb-xhci-nec when it is compiled in, Juan Quintela, 2018/08/22
- [Qemu-devel] [PATCH v3 01/10] configure: We don't want to clean configuration files, Juan Quintela, 2018/08/22
- [Qemu-devel] [PATCH v3 05/10] x86_64-softmmu: Configuration is identical to i386-softmmu, Juan Quintela, 2018/08/22
- [Qemu-devel] [PATCH v3 06/10] check: Only test ivshm when it is compiled in, Juan Quintela, 2018/08/22
- [Qemu-devel] [PATCH v3 08/10] check: Move VMXNET3 test to common, Juan Quintela, 2018/08/22