Re: [Qemu-devel] [PATCH v3 03/10] check: Only test isa-testdev when it is compiled in

[Juan Quintela]

Thomas Huth <address@hidden> wrote:
> On 2018-08-22 11:54, Juan Quintela wrote:
>> Once there, untangle endianness-test and boot-serial-test.
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>> 
>> --
>> 
>> boot-serial-test don't depend on isa-testdev.  Thanks Thomas.
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>
> Please remove the duplicated Sob.
>
>> @@ -321,15 +321,15 @@ check-qtest-m68k-y = tests/boot-serial-test$(EXESUF)
>>  
>>  check-qtest-microblaze-y = tests/boot-serial-test$(EXESUF)
>>  
>> -check-qtest-mips-y = tests/endianness-test$(EXESUF)
>> -
>> -check-qtest-mips64-y = tests/endianness-test$(EXESUF)
>> -
>> -check-qtest-mips64el-y = tests/endianness-test$(EXESUF)
>> -
>>  check-qtest-moxie-y = tests/boot-serial-test$(EXESUF)
>>  
>> -check-qtest-ppc-y = tests/endianness-test$(EXESUF)
>> +check-qtest-mips-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF)
>> +
>> +check-qtest-mips64-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF)
>> +
>> +check-qtest-mips64el-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF)
>> +
>> +check-qtest-ppc-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF)
>
> Maybe keep moxie after mips? So that they stay in alphabetical order?
>
> When you fixed the nits:
>
> Reviewed-by: Thomas Huth <address@hidden>

Done, thanks.