qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/9] qsp: QEMU's Synchronization Profiler


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 1/9] qsp: QEMU's Synchronization Profiler
Date: Tue, 21 Aug 2018 16:06:01 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 17/08/2018 07:18, Emilio G. Cota wrote:
> +
> +#define qemu_rec_trymutex_lock(m) ({                            \
> +            QemuRecMutexTrylockFunc _f;                         \
> +            _f = atomic_read(&qemu_rec_mutex_trylock_func);     \
> +            _f(m, __FILE__, __LINE__);                          \
> +        })
> +

Obvious typo (found by clang's -Winfinite-recursion, how it detects it
is left as an exercise to the reader; it's not obvious and I like this
clang warning even though the first impression is "why would you need
it"), fixed while applying.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]