Re: [Qemu-devel] [PATCH v2 00/60] json: Fixes, error reporting improvements, cleanups

[Fam Zheng]

On Mon, 08/20 10:31, Markus Armbruster wrote:
> address@hidden writes:
> 
> > Hi,
> >
> > This series seems to have some coding style problems. See output below for
> > more information:
> [...]
> > Checking PATCH 4/60: qmp-cmd-test: Split off qmp-test...
> > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> > #48: 
> > new file mode 100644
> 
> False positive: the patch does update MAINTAINERS.  Surprising, since
> commit 1a6fad0c3bd "checkpatch: reduce MAINTAINERS update message
> frequency" suppresses this.  Fam, is patchew running an outdated version
> of checkpatch?

I'm sure Patchew is using the latest checkpatch here. This is basically /me
reproducing what it does:

address@hidden:~/work/qemu [master]$ git fetch 
https://github.com/patchew-project/qemu tags/patchew/address@hidden
>From https://github.com/patchew-project/qemu
 * tag                     patchew/address@hidden -> FETCH_HEAD
address@hidden:~/work/qemu [master]$ git checkout FETCH_HEAD
Note: checking out 'FETCH_HEAD'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 884c1e75d7 json: Support %% in JSON strings when interpolating
address@hidden:~/work/qemu$ git log --oneline | grep 'qmp-cmd-test: Split off 
qmp-test'
b9ac2b614b qmp-cmd-test: Split off qmp-test
address@hidden:~/work/qemu$ git show --format=email b9ac2b614b | 
./scripts/checkpatch.pl -
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48:
new file mode 100644

total: 0 errors, 1 warnings, 460 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
address@hidden:~/work/qemu$ git log --oneline  ./scripts/checkpatch.pl | grep 
1a6fad0
1a6fad0c3b checkpatch: reduce MAINTAINERS update message frequency