[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy()
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy() |
Date: |
Fri, 17 Aug 2018 23:56:53 -0300 |
Fedora 29 comes with GCC 8.1 which added the 'stringop-truncation' checks.
Replace the strncpy() calls by g_strlcpy() to avoid the following warning:
migration/global_state.c: In function 'global_state_store_running':
migration/global_state.c:45:5: error: 'strncpy' specified bound 100 equals
destination size [-Werror=stringop-truncation]
strncpy((char *)global_state.runstate,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
state, sizeof(global_state.runstate));
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Howard Spoelstra <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
See http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg03723.html
migration/global_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/global_state.c b/migration/global_state.c
index 8e8ab5c51e..d5df502cd5 100644
--- a/migration/global_state.c
+++ b/migration/global_state.c
@@ -42,7 +42,7 @@ int global_state_store(void)
void global_state_store_running(void)
{
const char *state = RunState_str(RUN_STATE_RUNNING);
- strncpy((char *)global_state.runstate,
+ g_strlcpy((char *)global_state.runstate,
state, sizeof(global_state.runstate));
}
--
2.18.0
- [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy(),
Philippe Mathieu-Daudé <=
- Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy(), Juan Quintela, 2018/08/20
- Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy(), David Hildenbrand, 2018/08/20
- Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy(), Paolo Bonzini, 2018/08/20
- Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy(), David Hildenbrand, 2018/08/20
- Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy(), Thomas Huth, 2018/08/20
- Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy(), Eric Blake, 2018/08/20
- Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy(), David Hildenbrand, 2018/08/20
- Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy(), Thomas Huth, 2018/08/21
- Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy(), Paolo Bonzini, 2018/08/21
- Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy(), Juan Quintela, 2018/08/21