Re: [Qemu-devel] [PATCH v2 0/3] hw/pci: PCI resource reserve capability

[Marcel Apfelbaum]

Hi Jing,

On 08/16/2018 12:28 PM, Jing Liu wrote:
> This patch serial is about PCI resource reserve capability.
>
> First patch refactors the resource reserve fields in GenPCIERoorPort
> structure out to another new structure, called "PCIResReserve". Modify
> the parameter list of pci_bridge_qemu_reserve_cap_init().
>
> Then we add the teardown function called pci_bridge_qemu_reserve_cap_uninit().
>
> Last we enable the resource reserve capability for legacy PCI bridge
> so that firmware can reserve additional resources for the bridge.

The series looks good to me, please see some minor comments
in the patches.

Can you please point me to the SeaBIOS / OVMF counterpart?

Thanks,
Marcel


> Change Log:
> v2 -> v1
> * add refactoring patch
> * add teardown function
> * some other fixes
>
> Jing Liu (3):
>    hw/pci: factor PCI reserve resources to a separate structure
>    hw/pci: add teardown function for PCI resource reserve capability
>    hw/pci: add PCI resource reserve capability to legacy PCI bridge
>
>   hw/pci-bridge/gen_pcie_root_port.c | 32 +++++++++++++-------------
>   hw/pci-bridge/pci_bridge_dev.c     | 25 ++++++++++++++++++++
>   hw/pci/pci_bridge.c                | 47 +++++++++++++++++++++-----------------
>   include/hw/pci/pci_bridge.h        | 18 +++++++++++----
>   4 files changed, 80 insertions(+), 42 deletions(-)