[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 10/11] migration: remove the unnecessary RDMA
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v6 10/11] migration: remove the unnecessary RDMA_CONTROL_ERROR message |
Date: |
Fri, 17 Aug 2018 15:04:35 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
* Lidong Chen (address@hidden) wrote:
> It's not necessary to send RDMA_CONTROL_ERROR when clean up rdma resource.
> If rdma->error_state is ture, the message may not send successfully.
> and the cm event can also notify the peer qemu.
>
> Signed-off-by: Lidong Chen <address@hidden>
How does this keep 'cancel' working; I added 32bce196344 last year to
make that code also send the RDMA_CONTROL_ERROR in 'cancelling'.
Dave
> ---
> migration/rdma.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/migration/rdma.c b/migration/rdma.c
> index ae07515..e1498f2 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -2305,17 +2305,6 @@ static void qemu_rdma_cleanup(RDMAContext *rdma)
> int idx;
>
> if (rdma->cm_id && rdma->connected) {
> - if ((rdma->error_state ||
> - migrate_get_current()->state == MIGRATION_STATUS_CANCELLING) &&
> - !rdma->received_error) {
> - RDMAControlHeader head = { .len = 0,
> - .type = RDMA_CONTROL_ERROR,
> - .repeat = 1,
> - };
> - error_report("Early error. Sending error.");
> - qemu_rdma_post_send_control(rdma, NULL, &head);
> - }
> -
> rdma_disconnect(rdma->cm_id);
> trace_qemu_rdma_cleanup_disconnect();
> rdma->connected = false;
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v6 07/11] migration: poll the cm event while wait RDMA work request completion, (continued)
- [Qemu-devel] [PATCH v6 07/11] migration: poll the cm event while wait RDMA work request completion, Lidong Chen, 2018/08/06
- [Qemu-devel] [PATCH v6 05/11] migration: implement io_set_aio_fd_handler function for RDMA QIOChannel, Lidong Chen, 2018/08/06
- [Qemu-devel] [PATCH v6 08/11] migration: implement the shutdown for RDMA QIOChannel, Lidong Chen, 2018/08/06
- [Qemu-devel] [PATCH v6 11/11] migration: create a dedicated thread to release rdma resource, Lidong Chen, 2018/08/06
- [Qemu-devel] [PATCH v6 09/11] migration: poll the cm event for destination qemu, Lidong Chen, 2018/08/06
- [Qemu-devel] [PATCH v6 10/11] migration: remove the unnecessary RDMA_CONTROL_ERROR message, Lidong Chen, 2018/08/06
- Re: [Qemu-devel] [PATCH v6 10/11] migration: remove the unnecessary RDMA_CONTROL_ERROR message,
Dr. David Alan Gilbert <=