Re: [Qemu-devel] [PATCH 55/56] json: Clean up headers

[Eric Blake]

On 08/08/2018 07:03 AM, Markus Armbruster wrote:
> The JSON parser has three public headers, json-lexer.h, json-parser.h,
> json-streamer.h.  They all contain stuff that is of no interest
> outside qobject/json-*.c.
>
> Collect the public interface in include/qapi/qmp/json-parser.h, and
> everything else in qobject/json-parser-int.h.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

Nice separation.

>   10 files changed, 51 insertions(+), 76 deletions(-)
>   delete mode 100644 include/qapi/qmp/json-streamer.h
>   rename include/qapi/qmp/json-lexer.h => qobject/json-parser-int.h (62%)


> diff --git a/include/qapi/qmp/json-parser.h b/include/qapi/qmp/json-parser.h
> index 55f75954c3..7345a9bd5c 100644
> --- a/include/qapi/qmp/json-parser.h
> +++ b/include/qapi/qmp/json-parser.h
> @@ -1,5 +1,5 @@
>   /*
> - * JSON Parser
> + * JSON Parser

I'm not sure what git tried to flag here.

Otherwise, looks like a good reorganization.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org