[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v9 45/84] target/mips: Add emulation of DSP ASE for
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v9 45/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 4 |
Date: |
Thu, 16 Aug 2018 10:26:30 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/16/2018 07:57 AM, Aleksandar Markovic wrote:
> + switch (opc) {
> + case NM_POOL32AXF_2_0_7:
> + switch (extract32(ctx->opcode, 9, 3)) {
For future cleanup, I can't help but thinking you'd be better served by
extracting a different set of opcode bits and having a single switch.
That said, it all appears to all be correct, so
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v9 29/84] target/mips: Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV, (continued)
- [Qemu-devel] [PATCH v9 29/84] target/mips: Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 60/84] mips_malta: Add setting up GT64120 BARs to the nanoMIPS bootloader, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 37/84] target/mips: Add emulation of nanoMIPS 32-bit load and store instructions, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 38/84] target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 16/84] target/mips: Add preprocessor constants for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 49/84] target/mips: Add handling of ISA mode bit for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 58/84] elf: On elf loading, treat both EM_MIPS and EM_NANOMIPS as legal for MIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 45/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 4, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 45/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 4,
Richard Henderson <=
- [Qemu-devel] [PATCH v9 50/84] target/mips: Add updating BadInstr, BadInstrP, BadInstrX for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 55/84] elf: Add EM_NANOMIPS value as a valid one for e_machine field, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 61/84] mips_malta: Fix semihosting argument passing for nanoMIPS bare metal, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 65/84] linux-user: Add target_signal.h header for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 68/84] linux-user: Add target_fcntl.h header for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 63/84] elf: Add nanoMIPS specific variations in ELF header fields, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 67/84] linux-user: Update syscall_defs.h header for nanoMIPS, Aleksandar Markovic, 2018/08/16
- [Qemu-devel] [PATCH v9 71/84] linux-user: Add target_cpu.h header for nanoMIPS, Aleksandar Markovic, 2018/08/16