qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v9 45/84] target/mips: Add emulation of DSP ASE for


From: Richard Henderson
Subject: [Qemu-devel] [PATCH v9 45/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 4
Date: Thu, 16 Aug 2018 10:26:30 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 08/16/2018 07:57 AM, Aleksandar Markovic wrote:
> +    switch (opc) {
> +    case NM_POOL32AXF_2_0_7:
> +        switch (extract32(ctx->opcode, 9, 3)) {

For future cleanup, I can't help but thinking you'd be better served by
extracting a different set of opcode bits and having a single switch.

That said, it all appears to all be correct, so
Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]