Re: [Qemu-devel] ?==?utf-8?q? [PULL?==?utf-8?q? 00/19] MIPS queue for QEMU upstream, August 14, 2018

[Aleksandar Markovic]

These functions are used in the patches that follow in nanoMIPS series, but not 
submitted in this pull request.

Ok, I will reorganize the patches so that there is no such case, and will send 
the new pull request soon.

Do we require that bisect works for clang builds too (meaning that after each 
patch, clang build must be success)?

Aleksandar

-------- Original Message --------
Subject: Re: [PULL 00/19] MIPS queue for QEMU upstream, August 14, 2018
Date: Wednesday, August 15, 2018 21:20 CEST
From: Peter Maydell <address@hidden>
To: Aleksandar Markovic <address@hidden>
CC: QEMU Developers <address@hidden>
References: <address@hidden>


 On 14 August 2018 at 19:16, Aleksandar Markovic
<address@hidden> wrote:
> From: Aleksandar Markovic <address@hidden>
>
> The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866:
>
> Update version for v3.0.0 release (2018-08-14 16:38:43 +0100)
>
> are available in the git repository at:
>
> https://github.com/AMarkovic/qemu tags/mips-queue-aug-14-2018
>
> for you to fetch changes up to 20d4e01b6486b15d1f3d9ff2d51bba2bf00ebf94:
>
> qemu-doc: Amend MIPS-related items (2018-08-14 19:59:03 +0200)
>
> ----------------------------------------------------------------
> MIPS queue for QEMU upstream, August 14, 2018
>
> This is the first part of nanoMIPS support for QEMU. It contains
> various fixes and improvements that are related to nanoMIPS support,
> or are discovered while working on nanoMIPS support. Most of them are
> fairly simple changes, but each of them has its own significance and
> importance for nanoMIPS support.
>
> The second part that contains QEMU support for core nanoMIPS
> functionality will remain under review for some time.
>
> The third part that mainly contains Linux user support will likely
> remain under review for some longer period.
>
> ----------------------------------------------------------------

Hi; this fails to build on clang:

/home/petmay01/linaro/qemu-for-merges/target/mips/translate.c:1749:20:
error: unused function 'gen_op_addr_addi' [-Werror,-Wunused-funct
ion]
static inline void gen_op_addr_addi(DisasContext *ctx, TCGv ret, TCGv base,
^
/home/petmay01/linaro/qemu-for-merges/target/mips/translate.c:1921:20:
error: unused function 'check_xnp' [-Werror,-Wunused-function]
static inline void check_xnp(DisasContext *ctx)
^
2 errors generated.

The functions do appear to be genuinely unused.

thanks
-- PMM