Re: [Qemu-devel] [PATCH v4] tests/libqtest: Improve kill_qemu()

[Eric Blake]

On 08/15/2018 08:35 AM, Markus Armbruster wrote:

> > > > > /i386/ahci/sanity: tests/libqtest.c:119: kill_qemu() detected QEMU death from 
> > > > > signal 11 (Segmentation fault) (core dumped)
> > > >
> > > > Well, it would help if my commit message actually matched...

> > > > > +                const char *dump = WCOREDUMP(wstatus) ? " (dumped core)" : "";

> > > > ...the code.
> > >
> > > I got libqtest patches in my queue, and I could stick this patch in.
> > > Would you like me to touch up the commit message when I apply?  Or
> > > should I expect v5?
> >
> > If you don't mind doing the touchup (s/core dumped/dumped core/), then
> > I don't need to submit v5.
>
> Since "core dumped" is how the shell traditionally reports this, I'd
> prefer to adjust the code to match the commit message.  Okay?

Yes.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org