[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] monitor: show sync profiling info with 'inf
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] monitor: show sync profiling info with 'info sync' |
Date: |
Tue, 14 Aug 2018 10:14:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 13/08/2018 19:11, Emilio G. Cota wrote:
> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
> index 70639f656a..56a3249bad 100644
> --- a/hmp-commands-info.hx
> +++ b/hmp-commands-info.hx
> @@ -297,6 +297,22 @@ STEXI
> @item info opcount
> @findex info opcount
> Show dynamic compiler opcode counters
> +ETEXI
> +
> + {
> + .name = "sync",
> + .args_type = "max:i?",
> + .params = "[max]",
> + .help = "show sync profiling info for "
> + "up to max entries (default: 10). "
> + "Entries are sorted by wait time.",
> + .cmd = hmp_info_sync,
> + },
> +
> +STEXI
Would it make sense to add a flag to sort by average wait time, and one
to coalesce all mutexes for the same call site?
Can be done separately of course.
Paolo