Re: [Qemu-devel] [PATCH 36/56] json: Rename token JSON_ESCAPE & friends to JSON_INTERPOL

[Eric Blake]

On 08/08/2018 07:03 AM, Markus Armbruster wrote:
> The JSON parser optionally supports interpolation.  The code calls it
> "escape".  Awkward, because it uses the same term for escape sequences
> within strings.  The latter usage is consistent with RFC 7159 "The
> JavaScript Object Notation (JSON) Data Interchange Format" and ISO C.
> Call the former "interpolation" instead.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   include/qapi/qmp/json-lexer.h |  2 +-
>   qobject/json-lexer.c          | 64 +++++++++++++++++------------------
>   qobject/json-parser.c         |  8 ++---
>   3 files changed, 37 insertions(+), 37 deletions(-)

Mechanical, and a worthwhile name change.

Reviewed-by: Eric Blake <address@hidden>

Bike-shedding: Would INTERP (short for interpolate) be any more legible 
than INTERPOL (which I first read as short for 'international police')?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org