Re: [Qemu-devel] [PATCH] scripts/checkpatch.pl: Enforce multiline comment syntax

[Thomas Huth]

On 08/10/2018 02:45 PM, Paolo Bonzini wrote:
> On 10/08/2018 11:10, Peter Maydell wrote:
>>> So my proposal, which is actually consistent with what QEMU is doing, is
>>> the following:
>>>
>>> 1) the first line of a file should always be "/*", otherwise warn
>>>
>>> 2) a comment that starts with "/**" should have it on a lone line
>>>
>>> 3) every other multiline comment should start with
>>> "/*<whitespace><something>"
>> Personally I would prefer your suggestion, but as I say, there
>> was no consensus in the thread for it, and there was consensus
>> for "use the kernel's style here". I don't think we gain much
>> from reopening the debate at this point.
> 
> What we lose is that 3000 more new warnings appear.  So if we make an
> exception and convert all of the comments, I'm okay.

Why do you want to enforce to convert all of them in one go? For example
we still have also some TABs in some source files, and nobody cares
about converting them all in one go. If we enforce the comments in new
code, that should IMHO be good enough. Or make it a BiteSizeTask for the
next GSoC maybe.

> But otherwise, at least Eric, you, me (only now I admit), Thomas
> expressed a preference for the other style;

No, wait, you've got that wrong. I said that I don't like the asymetric
style that you're now trying to propagate again, but I'm fine with either

 /* dense comments
  * on multiple lines */

or

 /*
  * no dense comments
  * on multiple lines
  */

> on the other side it's
> Markus, Stefan, Conny and Alex, some of whom were okay with applying
> maintainer discretion; John and rth wanted a third one but disagreed on
> their second choice.  I appreciate your writing the patch, but I'm not
> sure that's consensus...

Count me in for the consensus on this other side, I really don't want
the asymetric style.

 Thomas