[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] tests: fix crumple/recursive leak
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] tests: fix crumple/recursive leak |
Date: |
Fri, 10 Aug 2018 08:25:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Spotted by ASAN:
>
> =================================================================
> ==27907==ERROR: LeakSanitizer: detected memory leaks
>
> Direct leak of 4120 byte(s) in 1 object(s) allocated from:
> #0 0x7f913458ce50 in calloc (/lib64/libasan.so.5+0xeee50)
> #1 0x7f9133fd641d in g_malloc0 (/lib64/libglib-2.0.so.0+0x5241d)
> #2 0x5561c6643c95 in qdict_crumple_test_recursive
> /home/elmarco/src/qq/tests/check-block-qdict.c:438
> #3 0x7f9133ff7c49 (/lib64/libglib-2.0.so.0+0x73c49)
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> tests/check-block-qdict.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/check-block-qdict.c b/tests/check-block-qdict.c
> index 478807f839..73d3e9f574 100644
> --- a/tests/check-block-qdict.c
> +++ b/tests/check-block-qdict.c
> @@ -491,6 +491,7 @@ static void qdict_crumple_test_recursive(void)
> empty_list_0 = qobject_to(QDict, qlist_pop(empty_list));
> g_assert(empty_list_0);
> g_assert_cmpint(qdict_size(empty_list_0), ==, 0);
> + qobject_unref(empty_list_0);
>
> qobject_unref(src);
> qobject_unref(dst);
Screwed up in commit 2860b2b2cb8. I can add that to the commit message
when I apply.
Reviewed-by: Markus Armbruster <address@hidden>
Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] tests: fix bdrv-drain leak, Max Reitz, 2018/08/13
[Qemu-devel] [PATCH 3/4] monitor: fix oob command leak, Marc-André Lureau, 2018/08/09