Re: [Qemu-devel] [PATCH v2 06/11] iotests: Add tests for mirror @replaces loops

[Max Reitz]

On 2018-08-10 00:31, Max Reitz wrote:
> This adds two tests for cases where our old check_to_replace_node()
> function failed to detect that executing this job with these parameters
> would result in a cyclic graph.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  tests/qemu-iotests/041     | 124 +++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/041.out |   4 +-
>  2 files changed, 126 insertions(+), 2 deletions(-)

Sometimes, I hate myself a little bit.  I totally forgot to run the test
with QED.

So:

> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
> index c20ac7da87..186bd0f031 100755
> --- a/tests/qemu-iotests/041
> +++ b/tests/qemu-iotests/041
> @@ -1061,5 +1061,129 @@ class TestOrphanedSource(iotests.QMPTestCase):

[...]

> +                        'driver': 'qcow2',

[...]

> +                            'driver': 'qcow2',

[...]

> +                    'driver': 'qcow2',

Imagine these to be "'driver': iotests.imgfmt".  With that, it passes.
(I won't send a v3 specifically for this, but it will be included in v3.
Eventually.)

Max

signature.asc
Description: OpenPGP digital signature