qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 09/34] tests/qgraph: pci-spapr driver and int


From: Emanuele
Subject: Re: [Qemu-devel] [PATCH v2 09/34] tests/qgraph: pci-spapr driver and interface nodes
Date: Thu, 9 Aug 2018 15:19:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1



On 08/09/2018 03:02 PM, Laurent Vivier wrote:
On 06/08/2018 16:33, Emanuele Giuseppe Esposito wrote:
+void qpci_init_spapr(QPCIBusSPAPR *ret, QTestState *qts, QGuestAllocator 
*alloc)
+{
      assert(qts);
+ /* tests cannot use spapr, needs to be fixed first */
+    ret->bus.has_buggy_msi = TRUE;
+
Perhaps you can revert the logic and call that "msi_is_available"?
It's more generic than "buggy". It says if we can or not use MSI.
This name was suggested by Paolo, I honestly don't know which is better, maybe it's better to ask him for this.
Thanks,
Laurent




reply via email to

[Prev in Thread] Current Thread [Next in Thread]