[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/34] tests/qgraph: pci-spapr driver and int
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/34] tests/qgraph: pci-spapr driver and interface nodes |
Date: |
Thu, 9 Aug 2018 15:02:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 06/08/2018 16:33, Emanuele Giuseppe Esposito wrote:
> +void qpci_init_spapr(QPCIBusSPAPR *ret, QTestState *qts, QGuestAllocator
> *alloc)
> +{
> assert(qts);
>
> + /* tests cannot use spapr, needs to be fixed first */
> + ret->bus.has_buggy_msi = TRUE;
> +
Perhaps you can revert the logic and call that "msi_is_available"?
It's more generic than "buggy". It says if we can or not use MSI.
Thanks,
Laurent
- Re: [Qemu-devel] [PATCH v2 05/34] tests/qgraph: sdhci driver and interface nodes, (continued)
- [Qemu-devel] [PATCH v2 06/34] tests/qgraph: sdhci test node, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 08/34] tests/qgraph: rename qpci_init_spapr functions, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 07/34] tests/qgraph: arm/raspi2 machine node, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 10/34] tests/qgraph: ppc64/pseries machine node, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 09/34] tests/qgraph: pci-spapr driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 11/34] test/qgraph: e1000e driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 01/34] tests: qgraph API for the qtest driver framework, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 12/34] test/qgraph: e1000e-test node, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 13/34] test/qgraph: virtio_start_device function, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 15/34] tests/qgraph: rename qvirtio_mmio_init_device functions, Emanuele Giuseppe Esposito, 2018/08/06