[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/56] check-qjson: Cover blank and lexically errone
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 02/56] check-qjson: Cover blank and lexically erroneous input |
Date: |
Wed, 8 Aug 2018 14:02:40 +0200 |
qobject_from_json() can return null without setting an error on
lexical errors. I call that a bug. Add test coverage to demonstrate
it.
Signed-off-by: Markus Armbruster <address@hidden>
---
tests/check-qjson.c | 36 +++++++++++++++++++++++++++++++++---
1 file changed, 33 insertions(+), 3 deletions(-)
diff --git a/tests/check-qjson.c b/tests/check-qjson.c
index cc952c56ea..81b92d6b0c 100644
--- a/tests/check-qjson.c
+++ b/tests/check-qjson.c
@@ -1307,8 +1307,36 @@ static void simple_varargs(void)
static void empty_input(void)
{
- const char *empty = "";
- QObject *obj = qobject_from_json(empty, &error_abort);
+ QObject *obj = qobject_from_json("", &error_abort);
+ g_assert(obj == NULL);
+}
+
+static void blank_input(void)
+{
+ QObject *obj = qobject_from_json("\n ", &error_abort);
+ g_assert(obj == NULL);
+}
+
+static void junk_input(void)
+{
+ /* Note: junk within strings is covered elsewhere */
+ Error *err = NULL;
+ QObject *obj;
+
+ obj = qobject_from_json("@", &err);
+ g_assert(!err); /* BUG */
+ g_assert(obj == NULL);
+
+ obj = qobject_from_json("[0\xFF]", &err);
+ error_free_or_abort(&err);
+ g_assert(obj == NULL);
+
+ obj = qobject_from_json("00", &err);
+ g_assert(!err); /* BUG */
+ g_assert(obj == NULL);
+
+ obj = qobject_from_json("[1e", &err);
+ g_assert(!err); /* BUG */
g_assert(obj == NULL);
}
@@ -1462,7 +1490,9 @@ int main(int argc, char **argv)
g_test_add_func("/varargs/simple_varargs", simple_varargs);
- g_test_add_func("/errors/empty_input", empty_input);
+ g_test_add_func("/errors/empty", empty_input);
+ g_test_add_func("/errors/blank", blank_input);
+ g_test_add_func("/errors/junk", junk_input);
g_test_add_func("/errors/unterminated/string", unterminated_string);
g_test_add_func("/errors/unterminated/escape", unterminated_escape);
g_test_add_func("/errors/unterminated/sq_string", unterminated_sq_string);
--
2.17.1
- [Qemu-devel] [PATCH 00/56] json: Fixes, error reporting improvements, cleanups, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 09/56] check-qjson: Cover escaped characters more thoroughly, part 2, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 02/56] check-qjson: Cover blank and lexically erroneous input,
Markus Armbruster <=
- [Qemu-devel] [PATCH 01/56] check-qjson: Cover multiple JSON objects in same string, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 06/56] test-qga: Clean up how we test QGA synchronization, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 14/56] check-qjson qmp-test: Cover control characters more thoroughly, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 22/56] json: Report first rather than last parse error, Markus Armbruster, 2018/08/08