[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] hw/misc/nrf51_rng: Add NRF51 random number
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/7] hw/misc/nrf51_rng: Add NRF51 random number generator peripheral |
|
Date: |
Mon, 6 Aug 2018 15:00:03 +0100 |
On Mon, Aug 6, 2018 at 11:01 AM, Steffen Görtz
<address@hidden> wrote:
> +#define NRF51_TRIGGER_TASK 0x01
> +#define NRF51_EVENT_CLEAR 0x00
Please consider putting these generic constants into hw/arm/nrf51.h or
a similar file that all nRF51 devices can include. That way code
duplication is eliminated.
Reviewed-by: Stefan Hajnoczi <address@hidden>