[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 01/12] migration: disable RDMA WRITE after postco
From: |
Lidong Chen |
Subject: |
[Qemu-devel] [PATCH v6 01/12] migration: disable RDMA WRITE after postcopy started |
Date: |
Fri, 3 Aug 2018 17:13:39 +0800 |
From: Lidong Chen <address@hidden>
RDMA WRITE operations are performed with no notification to the destination
qemu, then the destination qemu can not wakeup. This patch disable RDMA WRITE
after postcopy started.
Signed-off-by: Lidong Chen <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
---
migration/qemu-file.c | 8 ++++++--
migration/rdma.c | 12 ++++++++++++
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 0463f4c..977b9ae 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -253,8 +253,12 @@ size_t ram_control_save_page(QEMUFile *f, ram_addr_t
block_offset,
if (f->hooks && f->hooks->save_page) {
int ret = f->hooks->save_page(f, f->opaque, block_offset,
offset, size, bytes_sent);
- f->bytes_xfer += size;
- if (ret != RAM_SAVE_CONTROL_DELAYED) {
+ if (ret != RAM_SAVE_CONTROL_NOT_SUPP) {
+ f->bytes_xfer += size;
+ }
+
+ if (ret != RAM_SAVE_CONTROL_DELAYED &&
+ ret != RAM_SAVE_CONTROL_NOT_SUPP) {
if (bytes_sent && *bytes_sent > 0) {
qemu_update_position(f, *bytes_sent);
} else if (ret < 0) {
diff --git a/migration/rdma.c b/migration/rdma.c
index 8bd7159..76424a5 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -2921,6 +2921,10 @@ static size_t qemu_rdma_save_page(QEMUFile *f, void
*opaque,
CHECK_ERROR_STATE();
+ if (migrate_get_current()->state == MIGRATION_STATUS_POSTCOPY_ACTIVE) {
+ return RAM_SAVE_CONTROL_NOT_SUPP;
+ }
+
qemu_fflush(f);
if (size > 0) {
@@ -3480,6 +3484,10 @@ static int qemu_rdma_registration_start(QEMUFile *f,
void *opaque,
CHECK_ERROR_STATE();
+ if (migrate_get_current()->state == MIGRATION_STATUS_POSTCOPY_ACTIVE) {
+ return 0;
+ }
+
trace_qemu_rdma_registration_start(flags);
qemu_put_be64(f, RAM_SAVE_FLAG_HOOK);
qemu_fflush(f);
@@ -3502,6 +3510,10 @@ static int qemu_rdma_registration_stop(QEMUFile *f, void
*opaque,
CHECK_ERROR_STATE();
+ if (migrate_get_current()->state == MIGRATION_STATUS_POSTCOPY_ACTIVE) {
+ return 0;
+ }
+
qemu_fflush(f);
ret = qemu_rdma_drain_cq(f, rdma);
--
1.8.3.1
- [Qemu-devel] [PATCH v6 00/12] Enable postcopy RDMA live migration, Lidong Chen, 2018/08/03
- [Qemu-devel] [PATCH v6 01/12] migration: disable RDMA WRITE after postcopy started,
Lidong Chen <=
- [Qemu-devel] [PATCH v6 02/12] migration: create a dedicated connection for rdma return path, Lidong Chen, 2018/08/03
- [Qemu-devel] [PATCH v6 03/12] migration: avoid concurrent invoke channel_close by different threads, Lidong Chen, 2018/08/03
- [Qemu-devel] [PATCH v6 04/12] migration: implement bi-directional RDMA QIOChannel, Lidong Chen, 2018/08/03
- [Qemu-devel] [PATCH v6 06/12] migration: implement io_set_aio_fd_handler function for RDMA QIOChannel, Lidong Chen, 2018/08/03
- [Qemu-devel] [PATCH v6 05/12] migration: Stop rdma yielding during incoming postcopy, Lidong Chen, 2018/08/03
- [Qemu-devel] [PATCH v6 08/12] migration: poll the cm event while wait RDMA work request completion, Lidong Chen, 2018/08/03
- [Qemu-devel] [PATCH v6 07/12] migration: invoke qio_channel_yield only when qemu_in_coroutine(), Lidong Chen, 2018/08/03
- [Qemu-devel] [PATCH v6 09/12] migration: implement the shutdown for RDMA QIOChannel, Lidong Chen, 2018/08/03
- [Qemu-devel] [PATCH v6 11/12] migration: remove the unnecessary RDMA_CONTROL_ERROR message, Lidong Chen, 2018/08/03