[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/5] tests/vm: Propagate V=1 down into the make insi
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 3/5] tests/vm: Propagate V=1 down into the make inside the VM |
Date: |
Fri, 3 Aug 2018 09:52:28 +0100 |
Invoking 'make vm-build-freebsd' and friends with V=1 should
propagate that verbosity setting down into the build run
inside the VM. Make sure we do that. This brings it into
line with how the container tests handle V=1.
Signed-off-by: Peter Maydell <address@hidden>
---
tests/vm/Makefile.include | 1 +
docs/devel/testing.rst | 1 +
tests/vm/basevm.py | 5 ++++-
tests/vm/freebsd | 4 ++--
tests/vm/netbsd | 4 ++--
tests/vm/openbsd | 4 ++--
tests/vm/ubuntu.i386 | 2 +-
7 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
index 5daa2a3b732..2efc27961df 100644
--- a/tests/vm/Makefile.include
+++ b/tests/vm/Makefile.include
@@ -36,6 +36,7 @@ vm-build-%: tests/vm/%.img
$(if $(V)$(DEBUG), --debug) \
$(if $(DEBUG), --interactive) \
$(if $(J),--jobs $(J)) \
+ $(if $(V),--verbose) \
--image "$<" \
--build-qemu $(SRC_PATH), \
" VM-BUILD $*")
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 5e19cd50da8..56eed22a78b 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -423,6 +423,7 @@ Debugging
Add ``DEBUG=1`` and/or ``V=1`` to the make command to allow interactive
debugging and verbose output. If this is not enough, see the next section.
+``V=1`` will be propagated down into the make jobs in the guest.
Manual invocation
-----------------
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index ae9ab128c7b..bf8b1bcfc5e 100755
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -210,6 +210,8 @@ def parse_args(vm_name):
help="force build image even if image exists")
parser.add_option("--jobs", type=int, default=multiprocessing.cpu_count()
/ 2,
help="number of virtual CPUs")
+ parser.add_option("--verbose", "-V", action="store_true",
+ help="Pass V=1 to builds within the guest")
parser.add_option("--build-image", "-b", action="store_true",
help="build image")
parser.add_option("--build-qemu",
@@ -238,7 +240,8 @@ def main(vmcls):
vm.add_source_dir(args.build_qemu)
cmd = [vm.BUILD_SCRIPT.format(
configure_opts = " ".join(argv),
- jobs=args.jobs)]
+ jobs=args.jobs,
+ verbose = "V=1" if args.verbose else "")]
else:
cmd = argv
vm.boot(args.image + ",snapshot=on")
diff --git a/tests/vm/freebsd b/tests/vm/freebsd
index 2187a173274..795f739c7b3 100755
--- a/tests/vm/freebsd
+++ b/tests/vm/freebsd
@@ -23,8 +23,8 @@ class FreeBSDVM(basevm.BaseVM):
cd $(mktemp -d /var/tmp/qemu-test.XXXXXX);
tar -xf /dev/vtbd1;
./configure {configure_opts};
- gmake -j{jobs};
- gmake -j{jobs} check;
+ gmake -j{jobs} {verbose};
+ gmake -j{jobs} check {verbose};
"""
def build_image(self, img):
diff --git a/tests/vm/netbsd b/tests/vm/netbsd
index 2cc4798f0c4..c211672bcbd 100755
--- a/tests/vm/netbsd
+++ b/tests/vm/netbsd
@@ -23,8 +23,8 @@ class NetBSDVM(basevm.BaseVM):
cd $(mktemp -d /var/tmp/qemu-test.XXXXXX);
tar -xf /dev/rld1a;
./configure --python=python2.7 {configure_opts};
- gmake -j{jobs};
- gmake -j{jobs} check;
+ gmake -j{jobs} {verbose};
+ gmake -j{jobs} check {verbose};
"""
def build_image(self, img):
diff --git a/tests/vm/openbsd b/tests/vm/openbsd
index df6b79fe7dc..1e0c2500ad9 100755
--- a/tests/vm/openbsd
+++ b/tests/vm/openbsd
@@ -23,9 +23,9 @@ class OpenBSDVM(basevm.BaseVM):
cd $(mktemp -d /var/tmp/qemu-test.XXXXXX);
tar -xf /dev/rsd1c;
./configure --cc=x86_64-unknown-openbsd6.1-gcc-4.9.4
--python=python2.7 {configure_opts};
- gmake -j{jobs};
+ gmake -j{jobs} {verbose};
# XXX: "gmake check" seems to always hang or fail
- #gmake -j{jobs} check;
+ #gmake -j{jobs} check {verbose};
"""
def build_image(self, img):
diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386
index 059d295865c..7ea25327071 100755
--- a/tests/vm/ubuntu.i386
+++ b/tests/vm/ubuntu.i386
@@ -26,7 +26,7 @@ class UbuntuX86VM(basevm.BaseVM):
tar -xf /dev/vdb;
./configure {configure_opts};
make -j{jobs};
- make -j{jobs} check;
+ make check -j{jobs} {verbose};
"""
def _gen_cloud_init_iso(self):
--
2.17.1
- [Qemu-devel] [PATCH 0/5] tests/vm: various minor improvements, Peter Maydell, 2018/08/03
- [Qemu-devel] [PATCH 1/5] tests/vm: Use -cpu max rather than -cpu host, Peter Maydell, 2018/08/03
- [Qemu-devel] [PATCH 4/5] tests/vm: Bump guest RAM up from 2G to 4G, Peter Maydell, 2018/08/03
- [Qemu-devel] [PATCH 5/5] tests/vm: Use make's --output-sync option, Peter Maydell, 2018/08/03
- [Qemu-devel] [PATCH 2/5] tests/vm: Pass the jobs parallelism setting to 'make check', Peter Maydell, 2018/08/03
- [Qemu-devel] [PATCH 3/5] tests/vm: Propagate V=1 down into the make inside the VM,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 0/5] tests/vm: various minor improvements, Fam Zheng, 2018/08/03
- Re: [Qemu-devel] [PATCH 0/5] tests/vm: various minor improvements, Fam Zheng, 2018/08/03