[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Node deletion in aio_set_fd_handler
From: |
Fam Zheng |
Subject: |
[Qemu-devel] Node deletion in aio_set_fd_handler |
Date: |
Fri, 3 Aug 2018 10:42:17 +0800 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
Paolo, is this else branch dead code (or bug?):
/* If the lock is held, just mark the node as deleted */
if (qemu_lockcnt_count(&ctx->list_lock)) {
node->deleted = 1;
node->pfd.revents = 0;
} else {
/* Otherwise, delete it for real. We can't just mark it as
* deleted because deleted nodes are only cleaned up while
* no one is walking the handlers list.
*/
QLIST_REMOVE(node, node);
deleted = true;
}
Since we are in a qemu_lockcnt_lock/unlock section?
Fam
- [Qemu-devel] Node deletion in aio_set_fd_handler,
Fam Zheng <=