|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH v5 00/76] Add nanoMIPS support to QEMU |
Date: | Tue, 31 Jul 2018 15:43:03 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 07/30/2018 12:11 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic <address@hidden> > > v4->v5: > > - merged series "Mips maintenance and misc fixes and improvements" > and this one for easier handling (there are build dependencies) > - eliminated shadow variables from translate.c > - replaced shift/mask combination with extract32() > - added new function gen_op_addr_addi() > - added "fall through" comments at appropriate places > - eliminated micromips flag from I7200 definition > - numerous other enhancements originating from reviewer's > comments > - some of the patches split into two or more for easier > handling and review > - rebased to the latest code That concludes my review of this revision. It's quite a bit better, but there is still a lot of work to do. r~
[Prev in Thread] | Current Thread | [Next in Thread] |