Re: [Qemu-devel] [Qemu-ppc] [PATCH] sam460ex: Fix PCI interrupt connections

[BALATON Zoltan]

On Tue, 31 Jul 2018, Sebastian Bauer wrote:
> Am 2018-07-31 11:50, schrieb BALATON Zoltan:
> > On Tue, 31 Jul 2018, Sebastian Bauer wrote:
> > > There is also the possibility to make the special (num-irqs == 1) the 
> > > common case, as the Sam460ex platform is the only user of this bus so far 
> > > (and probably stays the only one). I'm not sure if it is worth all the 
> > > hassle.
> >
> > I'd vote for this as I've said before. This seems to be the simplest
> > solution so just change ppc440_pcix to have one irq instead of 4.
>
> I now think so too, as, when devising my initial patch, I was not aware of 
> the fact that this bus emulation was only created for the SAM.
>
> > > Let me know how to proceed.
> > Will you send an updated patch or should I take and modify your latest
> > one to help with this?
>
> I don't care so much about the how, but I would appreciate it, if the bug can 
> be fixed, so that further PCI cards can be used without too much hassle 
> (e.g., network cards). David seemed to be OK with my 2nd patch after I rebase 
> it if I understood it correctly. My plan is to do this. But I'll also submit 
> another alternative (shorter) patch that tailors the bus to the SAM only.

I've sent the shorter version as I think would be the easiest fix, please 
check if this is acceptable which may save you some work on updating your 
more complex patch which I think might not be needed at this point until 
something is found to need more interrupts in the ppc440_pcix model.

I've checked that this improves sound with ES1370, haven't checked with 
pci-ohci so you could verify that.

Regards,
BALATON Zoltan