Re: [Qemu-devel] [PATCH v5 07/76] elf: Remove duplicate preprocessor constant definition

[Laurent Vivier]

Le 30/07/2018 à 18:11, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic <address@hidden>
> 
> Remove duplicate preprocessor constant definition for EF_MIPS_ARCH.
> 
> The duplicate was introduced in commit 45506bdd.
> 
> Signed-off-by: Aleksandar Markovic <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
> ---
>  include/elf.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/elf.h b/include/elf.h
> index 934dbbd..c8aaa2a 100644
> --- a/include/elf.h
> +++ b/include/elf.h
> @@ -33,7 +33,6 @@ typedef int64_t  Elf64_Sxword;
>  
>  /* Flags in the e_flags field of the header */
>  /* MIPS architecture level. */
> -#define EF_MIPS_ARCH            0xf0000000
>  
>  /* Legal values for MIPS architecture level.  */
>  #define EF_MIPS_ARCH_1               0x00000000      /* -mips1 code.  */
> 

You should move the comment "MIPS architecture level" where the other
EF_MIPS_ARCH is defined (see glibc or system elf.h).

Thanks,
Laurent